RFR: 8287604: Update MarlinFX to 0.9.4.6 [v5]

Laurent Bourgès lbourges at openjdk.org
Wed Aug 10 08:24:52 UTC 2022


On Tue, 9 Aug 2022 14:52:12 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   upgraded to 0.9.4.6 (no repeated lineTo) + fixed tests
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/DualPivotQuicksort20191112Ext.java line 116:
> 
>> 114:      * @param high the index of the last element, exclusive, to be sorted
>> 115:      */
>> 116:     static void sort(DPQSSorterContext sorter, int[] a, int[] auxA, int[] b, int[] auxB, int low, int high) {
> 
> Here is one example of missing `@param` tags, in this case `sorter`, `auxA`, and `auxB`, but most methods are missing tags for some of their arguments.

Will fix javadoc in that class...

> modules/javafx.graphics/src/main/java/com/sun/marlin/Version.java line 30:
> 
>> 28: public final class Version {
>> 29: 
>> 30:     private static final String VERSION = "marlinFX-0.9.4.6-Unsafe-OpenJFX";
> 
> Can you change the title of the JBS bug and this PR to reflect the `.6` version bump?

Done

-------------

PR: https://git.openjdk.org/jfx/pull/674


More information about the openjfx-dev mailing list