RFR: 8289357: (Tree)TableView is null in (Tree)TableRowSkin during autosize [v6]

[Marius Hanl]

On Wed, 10 Aug 2022 19:50:02 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Marius Hanl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>> 
>>  - Added other ticket as reference in javadoc
>>  - Merge branch 'master' of https://github.com/openjdk/jfx into 8289357-table-view-null-in-table-row-skin
>>    
>>    
 Conflicts:
>>    
	modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java
>>    
	modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java
>>  - Enable tests again
>>  - Merge branch 'master' of https://github.com/openjdk/jfx into 8289357-table-view-null-in-table-row-skin
>>  - Merge branch 'master' of https://github.com/openjdk/jfx into 8289357-table-view-null-in-table-row-skin
>>  - 8289357: Added test to verify, that no (Tree)TableRows remain after auto sizing
>>  - 8289357: Fix test which failed as the coutner increased by one due to the now correct row setup
>>  - 8289357: Remove (Tree)TableRow after autosizing and update the index to -1 to prevent triggering of listener
>>  - 8289357: Initialize the (Tree)TableView when creating the measure row. Also prevent a NPE as we don't have a VirtualFlow in the context of autosizing
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 767:
> 
>> 765:         }
>> 766:         tableSkin.getChildren().remove(treeTableRow);
>> 767: 
> 
> would we need
> 
> treeTableRow.updateTreeTableView(null);
> 
> here to prevent a memory leak?

I don't think so. The row and cell should be gc'ed after this method since there are not used anywhere

-------------

PR: https://git.openjdk.org/jfx/pull/805