RFR: 8279514: NPE on clearing value of IntegerSpinnerValueFactory [v2]

Marius Hanl mhanl at openjdk.org
Thu Aug 11 09:31:34 UTC 2022


On Wed, 10 Aug 2022 09:40:02 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> A null check has been added to below SpinnerValueFactory classes in valueProperty() ChangeListeners-
>> - `IntegerSpinnerValueFactory`
>> - `LocalDateSpinnerValueFactory`
>> - `LocalTimeSpinnerValueFactory`
>> - `ListSpinnerValueFactory`
>> 
>> Added 5 tests that detect NPE for above 4 Spinner factories.
>> Only `DoubleSpinnerValueFactory` already had a valid null check - so the test for it passes before and after.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify null asserts

LGTM

-------------

Marked as reviewed by mhanl (Committer).

PR: https://git.openjdk.org/jfx/pull/865


More information about the openjfx-dev mailing list