RFR: 8290844: Add Skin.install() method [v2]

[Andy Goryachev]

On Thu, 11 Aug 2022 12:29:57 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8290844: javadoc
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 78:
> 
>> 76:     /**
>> 77:      * Called by {@link Control#setSkin(Skin)} on a pristine control, or after the
>> 78:      * previous skin has been uninstalled via its {@link #dispose()} method.
> 
> Hmm .. as formulated that sounds to me like an implementation detail of Control (which shouldn't appear here). We might think of something unrelated to specific users.
> 
> Also: the congenial partner of a Skin is a Skinnable - all narrowing to a special implementator of Skinnable here should be avoided. We have an open issue for the invers, that is Skinnable overspecifying itself as Control [JDK-8260364](https://bugs.openjdk.org/browse/JDK-8260364)

Reworded the description to refer to Skinnable.setSkin().  I feel it is important to mention where in the life cycle of the Skin the install() is getting invoked, without changing too much, but any suggestions will be greatly appreciated!

-------------

PR: https://git.openjdk.org/jfx/pull/845