RFR: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar. [v2]
Marius Hanl
mhanl at openjdk.org
Thu Aug 11 20:55:06 UTC 2022
On Wed, 10 Aug 2022 18:54:47 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> @kevinrushforth We can consider EPSILON with value of `.0000001`. This value is already used in the same method for another bounds checking. Below is the part of the code where it is used..
>>
>> // Check for zero. This happens when the distribution of the delta
>> // finishes early due to a series of "fixed" entries at the end.
>> // In this case, lowerBound == upperBound, for all subsequent terms.
>> double newSize;
>> if (Math.abs(totalLowerBound - totalUpperBound) < .0000001) {
>> newSize = lowerBound;
>> } else {
>> double f = (target - totalLowerBound) / (totalUpperBound - totalLowerBound);
>> newSize = Math.round(lowerBound + f * (upperBound - lowerBound));
>> }
>
> I am also for declaring a constant
>
>
> private static final double EPSILON = .0000001;
>
>
> and using it in on lines 226 and 251.
Just a question out of curiosity, is there some kind of recommended value for epsilon?
I remember we also have very small epsilon in `Region` for snapping.
-------------
PR: https://git.openjdk.org/jfx/pull/848
More information about the openjfx-dev
mailing list