RFR: 8291908: VirtualFlow creates unneeded empty cells
Kevin Rushforth
kcr at openjdk.org
Thu Aug 11 23:46:31 UTC 2022
On Thu, 4 Aug 2022 14:30:40 GMT, Johan Vos <jvos at openjdk.org> wrote:
> When calculating the viewportOffset, we now already take into account that cells will have to shift.
>
> This prevents the creation of temporary empty cells in the layout phase.
> One test needed to be fixed, since the number of invocations to updateItem() was hardcoded (and it
> is decreased by this commit).
This fix looks good. I confirmed that the new test fails without the fix and passes with the fix. I also confirmed that this also fixes [JDK-8291467](https://bugs.openjdk.org/browse/JDK-8291467).
@johanvos As noted in JBS, this PR also fixes [JDK-8291467](https://bugs.openjdk.org/browse/JDK-8291467). Can you add that issue to this PR? Alternatively, you could change [JDK-8291908](https://bugs.openjdk.org/browse/JDK-8291908) to a bug and close JDK-8291467 as a duplicate.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/863
More information about the openjfx-dev
mailing list