RFR: 8290844: Add Skin.install() method [v2]

Jeanette Winzenburg fastegal at openjdk.org
Fri Aug 12 14:48:27 UTC 2022


On Thu, 11 Aug 2022 23:24:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> 
> How common do you think this sort of thing is in practice? 

can't do more than guessing (knowing that companies I worked for had done so before I got my hands onto their code) - so would say it's common enough to cause .. well, some distress ;)

> This does suggest that we ought to take a cautious approach, only overriding and implementing `Skin::install` for those built-in controls where it is needed to fix bugs. It also suggests that this possible incompatibility ought to be highlighted in a release note (in addition to updating the CSR, which Andy has indicated that he will do).

Agreed. The part open to discussion is "needed to fix bugs". So far, we have identified (Andy, correct me if I'm wrong - you are nearer to the current state than I am :) only one [JDK-8268877](https://bugs.openjdk.org/browse/JDK-8268877) that can't be handled without some kind of api change (which in that particular case might be a marker interface like UIResource in Swing to allow skins to differentiate between control- and skin installed handlers :). There probably are more in skins that are not yet cleaned.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list