RFR: 8290844: Add Skin.install() method [v3]
Andy Goryachev
angorya at openjdk.org
Fri Aug 12 18:04:23 UTC 2022
On Fri, 12 Aug 2022 17:51:20 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Good point!
>> Actually, unbind() is sufficient, as it does the required check. From javadoc: _If the Property is not bound, calling this method has no effect._
>> Is there another reason to call isBound(), perhaps for clarity?
>
> Good question. I do see the check in other places where an exception is thrown from invalidated, such as TextField, TextArea, TableColumnHeader. More importantly, those properties also restore their previous value (irrespective of binding), which we might want to consider here.
will unbind and restore the old value. thanks!
-------------
PR: https://git.openjdk.org/jfx/pull/845
More information about the openjfx-dev
mailing list