RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

[Kevin Rushforth]

On Sat, 13 Aug 2022 13:24:30 GMT, Laurent Bourgès <lbourges at openjdk.org> wrote:

>> Changelog for this MarlinFX 0.9.4.6 release:
>> 
>> The Marlin-renderer 0.9.4.6 release provides one bug fix in Stroker: skip repeated endpoint to preserve mitter orientation: see JDK-8264999, https://bugs.openjdk.org/browse/JDK-8264999
>> 
>> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path clipper:
>> - improved Stroker to handle huge coordinates, up to 1E15
>> - improved PathClipFilter (filler) to handle huge coordinates, up to 1E15
>> See JDK-8274066, https://bugs.openjdk.org/browse/JDK-8274066
>> 
>> 
>> This is the Marlin-renderer 0.9.4.3 release providing few bug / enhancement fixes in the MarlinRenderingEngine:
>> - Update DPQS to latest OpenJDK 14 patch
>> - Improve cubic curve offset computation
>> 
>> 
>> The Marlin-renderer 0.9.4.2 release provides a single long-standing bug fix in the MarlinRenderingEngine: 
>> - JDK-8230728, https://bugs.openjdk.java.net/browse/JDK-8230728.
>> 
>> 
>> Marlin-renderer 0.9.4.1 provides only a single bug fix in the path clipper, reported first against JavaFX 11: 
>> - JDK-8226789, https://bugs.openjdk.java.net/browse/JDK-8226789.
>> 
>> 
>> This is the Marlin-renderer 0.9.4 release providing an updated Dual Pivot Quick Sort (19.05) as its internal sorter faster than the Marlin's optimized MergeSort (x-position + edge indices) for arrays larger than 256.
>> 
>> Special Thanks to Vladimir Yaroslavskiy that provided me up-to-date DPQS 19.05 with many variants, improving almost-sorted datasets. We are collaborating to provide a complete Sort framework (15 algorithms, many various datasets, JMH benchmarks) publicly on github:
>> see https://github.com/bourgesl/nearly-optimal-mergesort-code
>
> Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed dpqs javadoc + tests (setupOnce)

Looks good. I did leave one question and a (minor) comment.

modules/javafx.graphics/src/main/java/com/sun/marlin/DualPivotQuicksort20191112Ext.java line 52:

> 50: public final class DualPivotQuicksort20191112Ext {
> 51: 
> 52:     private static final boolean FAST_ISORT = true;

How much testing have you done with this flag set to true?

modules/javafx.graphics/src/main/java/com/sun/marlin/DualPivotQuicksort20191112Ext.java line 784:

> 782:      * @param srcB the source array for the secondary array to be ordered (b)
> 783:      * @param offset the start index in the source, inclusive
> 784:      * @param dstB the temporary buffer used in merging (b)

Minor: this should probably be moved before `offset`

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/674