RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v7]

Ajit Ghaisas aghaisas at openjdk.org
Wed Aug 17 06:39:29 UTC 2022


On Fri, 12 Aug 2022 15:08:27 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>>> 
>>> The tests were added to both TableViewSelectionModelImplTest and TreeTableViewSelectionModelImplTest.
>> 
>> hmm .. in TreeTableViewSelectionModelImplTest, I don't see any of the  testRowSelectionAfterSelectAndHideLastColumnXX nor testSelectRowWhenInSingleCellSelectionModeIsSelected, what am I missing?
>
>> hmm .. in TreeTableViewSelectionModelImplTest, I don't see any of the testRowSelectionAfterSelectAndHideLastColumnXX nor testSelectRowWhenInSingleCellSelectionModeIsSelected, what am I missing?
> 
> you are right... I am so sorry.  missed this one while cherry picking from another branch.  will fix it soon.
> 
> would it be possible to review https://github.com/openjdk/jfx/pull/858 so there is no need to cherry pick, please?

I see a very good progress on this PR. Thanks @andy-goryachev-oracle and @kleopatra !
Only thing that needs to be corrected is - the PR description has become out of date with all the review change fixes.

-------------

PR: https://git.openjdk.org/jfx/pull/839


More information about the openjfx-dev mailing list