RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v10]

Andy Goryachev angorya at openjdk.org
Wed Aug 17 15:27:34 UTC 2022


On Mon, 15 Aug 2022 10:29:17 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> unnecessary in the case of TableRow.
>> the change in TreeTableRow was necessary because otherwise selecting a cell by mouse selected the whole row.
>
>> unnecessary in the case of TableRow. 
> 
> that is .. why exactly?
> 
>> the change in TreeTableRow was necessary because otherwise selecting a cell by mouse selected the whole row.
> 
> it still does (if all cells are selected)
> 
> see me in grinning - my first guess was exactly the same as yours, but the moment I was about answering your comment (with "should behave the same and _they do_") some memory neuron fired and made me curious enough the check. The outcome is [JDK-8292353](https://bugs.openjdk.org/browse/JDK-8292353)
> 
> as that is unrelated to this fix (same before/after), we are fine here

[JDK-8292353](https://bugs.openjdk.org/browse/JDK-8292353) can be trivially fixed (PR to be filed).

-------------

PR: https://git.openjdk.org/jfx/pull/839


More information about the openjfx-dev mailing list