RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v11]

[Kevin Rushforth]

On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect statement "Is functionally equivalent to calling <code>getSelectedIndices().contains(index)</code>." 
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to return true when at least one cell in *any* column is selected on the given row (was: *all* columns)
>> 3. modified TreeTableRow.updateSelection() to use the right isSelected() method
>> 4. updated tests for Tree/TableView
>> 
>> NOTE: proposed change alters semantics of isSelected(int) method (in the right direction, in my opinion).
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8235491: added tests

This all looks good to me now. I left one comment on the CSR, and I'll review that once that is done.

This will give @aghaisas a chance to review as well.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/839