RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode
Jeanette Winzenburg
fastegal at openjdk.org
Thu Aug 18 09:54:35 UTC 2022
On Wed, 17 Aug 2022 19:40:21 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> The issue is caused by TreeTableRow incorrectly selected when cell selection mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Changes requested by fastegal (Reviewer).
modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java line 448:
> 446: }
> 447:
> 448: boolean isSelected = !sm.isCellSelectionEnabled() && sm.isSelected(index, null);
this is different from TableRow (which uses isSelected(index)) - why?
And we don't seem to have complete test coverage for row selection (otherwise this issue would have shown somewhere :) - please add test/s that fail/pass before/after the fix, respectively
-------------
PR: https://git.openjdk.org/jfx/pull/875
More information about the openjfx-dev
mailing list