[jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

Kevin Rushforth kcr at openjdk.org
Sat Aug 20 00:33:32 UTC 2022


On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> Added docs for inherited methods in `Bindings` subclasses.

Looks fine. I left a question about the missing `@return` tags, but it might not matter here depending on whether the IDEs care.

modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java line 174:

> 172:             /**
> 173:              * Returns an immutable list of the dependencies of this binding.
> 174:              */

Does the missing `@return` tag matter here? It isn't public docs so might not matter. The same question applies to the other instances of this overridden method.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/881


More information about the openjfx-dev mailing list