RFR: 8292391: Add support for optional signing of native libraries

Ambarish Rapte arapte at openjdk.org
Tue Aug 23 09:38:41 UTC 2022


On Tue, 16 Aug 2022 21:14:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> This PR enables an optional signing step inserted into the build right after the step to strip binaries that was added by [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260). As is the case with the `strip` step, the optional signing is only ever enabled for production builds when running with `gradle -PCONF=Release`.
> 
> This is an optional step, meaning that `codeSignCmd` and `codeSignArgs` need to be provided by scripts external to the repo in order to enable it. By default, they are not defined, so the additional logic added by this PR will do nothing.
> 
> NOTE: as with the fix for [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260), this PR adds three copies of the build logic. I filed [JDK-8292506](https://bugs.openjdk.org/browse/JDK-8292506) to refactor both of them (strip and sign), and to look for other duplication as well.

Marked as reviewed by arapte (Reviewer).

-------------

PR: https://git.openjdk.org/jfx/pull/871


More information about the openjfx-dev mailing list