[jfx19] RFR: 8286678: Fix mistakes in FX API docs [v2]

Nir Lisker nlisker at openjdk.org
Tue Aug 23 11:46:48 UTC 2022


On Mon, 22 Aug 2022 22:21:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java line 130:
> 
>> 128:  * will treat that duration as if it were Duration.ZERO. Likewise, any Duration which answers true
>> 129:  * to {@link javafx.util.Duration#isIndefinite()} will be treated as if it were a duration of Double.MAX_VALUE
>> 130:  * milliseconds. Any {@code null} Duration is treated as Duration.ZERO. Any custom implementation of a backoff strategy
> 
> Since you changed `null` to use code style, maybe also do it for `Duration.ZERO`?

There are many places that are missing it in this class. Should I do them all while here?

> modules/javafx.graphics/src/main/java/javafx/concurrent/Service.java line 102:
> 
>> 100:  *     Because a Service is intended to simplify declarative use cases, subclasses
>> 101:  *     should expose as properties the input parameters to the work to be done.
>> 102:  *     For example, suppose I wanted to write a Service that reads the first line
> 
> As long as you are changing this sentence, can you also change `I` to `you`? The unintended use of first person here is a bit jarring.

I rephrased the sentence.

-------------

PR: https://git.openjdk.org/jfx/pull/880


More information about the openjfx-dev mailing list