[jfx19] RFR: 8286678: Fix mistakes in FX API docs [v3]

Kevin Rushforth kcr at openjdk.org
Tue Aug 23 12:02:38 UTC 2022


On Tue, 23 Aug 2022 11:46:47 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressed review comments

modules/javafx.graphics/src/main/java/javafx/concurrent/Service.java line 104:

> 102:  *     For example, to write a Service that reads the first line
> 103:  *     from any URL and returned it as a String, it might be defined
> 104:  *     such that it had a single property, {@code url}, and might be implemented

I like the rewrite, although a couple of the verb tenses are now mismatched:

"returned" --> "returns"
"had" --> "has" (or replace "such that it had" by "with")

-------------

PR: https://git.openjdk.org/jfx/pull/880


More information about the openjfx-dev mailing list