RFR: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting [v5]
Andy Goryachev
angorya at openjdk.org
Tue Aug 23 20:20:11 UTC 2022
> Setting a null selection model in TableView and TreeTableView produce NPE on sorting (and probably in some other situations) because the check for null is missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a (tree)table.
>
> There is also a similar issue with ListView [JDK-8279640](https://bugs.openjdk.org/browse/JDK-8279640).
>
> changes:
> - added check for null selection model where it was missing
> - clear focused row index on setting null selection model in TreeTableView
> - clear selected cells on setting a new selection model
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
- Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
- 8187145: added tests
- 8187145: clear selected tree table row when setting null selection model
- 8187145: clear selection when setting selection model
- Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
- Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
- 8187145: whitespace
- 8187145: clear focus
- 8187145: tree table view
- 8187145: fall through
- ... and 1 more: https://git.openjdk.org/jfx/compare/7cb8d679...fed5dfdb
-------------
Changes: https://git.openjdk.org/jfx/pull/876/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=876&range=04
Stats: 432 lines in 13 files changed: 335 ins; 11 del; 86 mod
Patch: https://git.openjdk.org/jfx/pull/876.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/876/head:pull/876
PR: https://git.openjdk.org/jfx/pull/876
More information about the openjfx-dev
mailing list