RFR: 8290765: Remove parent disabled/treeVisible listeners
Ambarish Rapte
arapte at openjdk.org
Thu Aug 25 07:47:54 UTC 2022
On Thu, 21 Jul 2022 04:43:15 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
> `Node` adds InvalidationListeners to its parent's `disabled` and `treeVisible` properties and calls its own `updateDisabled()` and `updateTreeVisible(boolean)` methods when the property values change.
>
> These listeners are not required, since `Node` can easily call the `updateDisabled()` and `updateTreeVisible(boolean)` methods on its children, saving the memory cost of maintaining listeners and bindings.
Tested with some layout and controls. LGTM.
-------------
Marked as reviewed by arapte (Reviewer).
PR: https://git.openjdk.org/jfx/pull/841
More information about the openjfx-dev
mailing list