RFR: 8087673: [TableView] TableView and TreeTableView menu button overlaps columns when using a constrained resize policy. [v3]

[Andy Goryachev]

On Tue, 30 Aug 2022 09:06:36 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 381:
>> 
>>> 379:         }
>>> 380: 
>>> 381:         double cornerRegionPadding = tableHeaderRow == null ? 0d : tableHeaderRow.cornerPadding.get();
>> 
>> minor: could we use consistent 0 or 0.0 or 0d?
>> (I'd suggest 0.0 to avoid int->double conversion, or 0d as very few people use 0d)
>
> Indeed it is not consistent at all throughout all the source code...
> 
>> or 0d as very few people use 0d
> 
> do you mean `or 0 as very few people use 0d` or `or 0d as very few people use 0`? 
> 
> Checking Controls source code, doubles use `0` or `0d` or `0.0d` as well as 0.0, so it will be hard to be consistent without making too many changes... For instance, next line is `double sortWidth = 0;`. If I go to 0.0, should I change it as well?

few people use 0d.

-------------

PR: https://git.openjdk.org/jfx/pull/886