RFR: 8294589: MenuBarSkin: memory leak when changing skin [v17]

Andy Goryachev angorya at openjdk.org
Thu Dec 1 17:04:15 UTC 2022


> Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().
> 
> This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull/908

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 49 commits:

 - Merge remote-tracking branch 'origin/master' into
   8294589.menubarskin.leak
 - 8294589: review comments
 - 8294589: cleanup
 - Merge remote-tracking branch 'origin/master' into
   8294589.menubarskin.leak
 - 8294589: testing github merge-conflict label behavior
 - 8294589: cleanup
 - Merge remote-tracking branch 'origin/master' into
   8294589.menubarskin.leak
 - Merge branch '8294809.listener.helper' into 8294589.menubarskin.leak
 - 8294809: generics
 - 8294589: owner
 - ... and 39 more: https://git.openjdk.org/jfx/compare/4a19fe71...b51db815

-------------

Changes: https://git.openjdk.org/jfx/pull/906/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=906&range=16
  Stats: 470 lines in 2 files changed: 234 ins; 205 del; 31 mod
  Patch: https://git.openjdk.org/jfx/pull/906.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/906/head:pull/906

PR: https://git.openjdk.org/jfx/pull/906


More information about the openjfx-dev mailing list