RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true

Karthik P K duke at openjdk.org
Fri Dec 2 05:29:55 UTC 2022


Cause: When slider is dragged for first time after tooltip appears, setOnMousePressed event was not invoked, hence dragStart was null in the subsequently invoked event handler (setOnMouseDragged).

Fix: Initialized dragStart in initialize method.

Test: Added system test to validate the fix.

Note: Initializing dragStart in layoutChildren method as suggested in the bug was causing side effects. Hence initialized dragStart in initialize method.

-------------

Commit messages:
 - Correct file permissions
 - Correct line endings
 - Merge branch 'master' into slider_npe_fix
 - SliderSkin NPE fix

Changes: https://git.openjdk.org/jfx/pull/965/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=965&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8190411
  Stats: 152 lines in 2 files changed: 152 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/965.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/965/head:pull/965

PR: https://git.openjdk.org/jfx/pull/965


More information about the openjfx-dev mailing list