RFR: 8295500: AccordionSkin: memory leak when changing skin [v3]

Ajit Ghaisas aghaisas at openjdk.org
Fri Dec 2 09:46:20 UTC 2022


On Thu, 1 Dec 2022 17:09:50 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> as determined by SkinMemoryLeakTest (remove line 164) and a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>> 
>> Make sure to configure the current test in LeakTest:
>> protected final Type WE_ARE_TESTING = Type.ACCORDION;
>> 
>> 
>> caused by:
>> - adding and not removing listeners
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
> 
>  - 8295500: cleanup
>  - Merge remote-tracking branch 'origin/master' into 8295500.accordion.skin
>  - Merge remote-tracking branch 'origin/master' into 8295500.accordion.skin
>  - 8295500: cleanup
>  - Merge remote-tracking branch 'origin/master' into 8295500.accordion.skin
>  - Merge branch '8294809.listener.helper' into 8295500.accordion.skin
>  - 8294809: generics
>  - Merge branch '8294809.listener.helper' into 8295500.accordion.skin
>  - 8294809: is alive
>  - Merge branch '8294809.listener.helper' into 8295500.accordion.skin
>  - ... and 19 more: https://git.openjdk.org/jfx/compare/4a19fe71...8da3b64f

Looks good to me!

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/920


More information about the openjfx-dev mailing list