RFR: 8276170: Create Sources when publishing to Maven

Johan Vos jvos at openjdk.org
Fri Dec 2 15:55:28 UTC 2022


On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv <duke at openjdk.org> wrote:

> Create sources.jars and attach they to the publish task, so that they can be uploaded to the (e.g. maven) repository automatically.

I think there is some confusion, so let me clarify.
My intention was never to remove or stop building the maven artifacts. Those are extremely important and heavily used, and we will keep them, and keep uploading new artifacts (including ea versions) to maven central. There are also no plans to stop the javafx maven and gradle plugins, so we continue maintaining those.

However, I think having the maven build logic (for building OpenJFX artifacts, not for building JavaFX apps with OpenJFX artifacts) inside the same file (build.gradle) as all the build logic for OpenJFX makes things overcomplicated. The build.gradle file in the OpenJFX repository is imho too complex and does too many things. Every line that is added inside this file makes the maintenance of OpenJFX harder.I  personally would like to have an approach similar to OpenJDK, which is more Makefile based and deals with module/platform/architecture specific things in a cleaner way. However, it would be a huge effort to move from the monolith build.gradle that we currently have towards a system like OpenJDK -- especially since we need to get all testing and all cornercases 100% correct -- so it's not on my personal short-term roadmap.

So what I regret is that I wanted to have the artifact build logic inside the monolithic build.gradle file. I believe that was a mistake that we have to fix, and in doing so we can improve the process (e.g. by adding the source builds). I should have commented on the PR, and I want to apologize (especially to @eduardsdv ) because I failed to do so. 

-------------

PR: https://git.openjdk.org/jfx/pull/657


More information about the openjfx-dev mailing list