RFR: 8245145: Spinner: throws IllegalArgumentException when replacing skin [v3]

Andy Goryachev angorya at openjdk.org
Fri Dec 2 17:42:00 UTC 2022


> Fixed SpinnerSkin initialization using new Skin.install().  Also in this PR - fixing memory leaks in SpinnerSkin by properly removing all listeners and event filters added in the constructor, as well as any child Nodes.
> 
> NOTE: the fix requires both ListenerHelper [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) and Skin.install() [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 51 commits:

 - Merge remote-tracking branch 'origin/master' into 8245145.spinner.skin
 - Merge remote-tracking branch 'origin/master' into 8245145.spinner.skin
 - 8245145: cleanup
 - 8245145: cleanup
 - 8245145: cleanup
 - Merge remote-tracking branch 'origin/master' into 8245145.spinner.skin
 - 8245145: listener helper
 - Merge branch '8294809.listener.helper' into 8245145.spinner.skin
 - 8294809: whitespace
 - 8294809: no public api
 - ... and 41 more: https://git.openjdk.org/jfx/compare/e64e1292...c933b7b5

-------------

Changes: https://git.openjdk.org/jfx/pull/904/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=904&range=02
  Stats: 58 lines in 3 files changed: 33 ins; 12 del; 13 mod
  Patch: https://git.openjdk.org/jfx/pull/904.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/904/head:pull/904

PR: https://git.openjdk.org/jfx/pull/904


More information about the openjfx-dev mailing list