Integrated: 8297362: EOS might not be delivered by progressbuffer in some cases

Alexander Matveev almatvee at openjdk.org
Sat Dec 3 00:17:04 UTC 2022


On Wed, 23 Nov 2022 00:57:11 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> This is regression from [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352). [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing pending events in progress buffer when upstream sends EOS. We need to do this for any other events except EOS. If we clear pending EOS, then it will not be delivered and we will hang due to downstream waiting for data or EOS. We still need to clear any other events such as new segment and not deliver it once we receive EOS.
> 
> Added "plugins" folder to macOS project. For some reason it was missing and debugging plugins with xcode was not possible.
> 
> Tested on all platforms with all formats over FILE and HTTP protocol. EOS was delivered correctly in all cases.

This pull request has now been integrated.

Changeset: 9416874f
Author:    Alexander Matveev <almatvee at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/9416874f632d8d036a324e195fae58e6a831bfc5
Stats:     20 lines in 2 files changed: 16 ins; 0 del; 4 mod

8297362: EOS might not be delivered by progressbuffer in some cases

Reviewed-by: kcr, arapte

-------------

PR: https://git.openjdk.org/jfx/pull/961


More information about the openjfx-dev mailing list