RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v3]

John Hendrikx jhendrikx at openjdk.org
Sat Dec 3 20:50:44 UTC 2022


On Sat, 26 Nov 2022 18:19:00 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert changes to gesture recognizers to be addressed in follow up bug
>>  - Fix incorrect cast removals
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxStatefulMultiTouchProcessor.java line 42:
> 
>> 40: 
>> 41:     private final Map<Integer, Integer> slotToIDMap =
>> 42:             new HashMap<>();
> 
> Same line. There are more places where this formatting can be fixed, but it's up to you.

I'll only fix the lines that were touched, as there are many many places that could be written more succinct.

> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinHTMLCodec.java line 157:
> 
>> 155:                 htmlPrefix = "<HTML>";
>> 156:                 htmlSuffix = "</HTML>";
>> 157:                 if( -1 == stUpContext.indexOf("<BODY") ) {
> 
> Might as well fix the spacing for `if`.

I've left this as is (even though I agree this is ugly), as I didn't touch that line. Fixing these issues is a slippery slope :)

-------------

PR: https://git.openjdk.org/jfx/pull/960


More information about the openjfx-dev mailing list