RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v3]
John Hendrikx
jhendrikx at openjdk.org
Sat Dec 3 20:50:45 UTC 2022
On Tue, 29 Nov 2022 16:49:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> +1 for reverting the changes and disabling the warning
>
>> Specifically about this code, `rotationStartTime` probably should not have been a `double` depending on what is stored in it (checking: its source is `System.nanoTime()`) as the conversion from `long` to `double` will lose precision in the area where it really counts as it wants to see the difference of the current and last value, so in this case the warning may have exposed a (precision) bug.
>
> You may be right. In this case, I would recommend either reverting this change, or else adding a `.0` to the divisor along with the removal of the explicit cast. Either way, we should consider a follow-up bug to address the question of possible loss of precision (in the existing code, which is unchanged by the refactoring).
I've reverted the changes to the gesture recognizers and filed https://bugs.openjdk.org/browse/JDK-8298060
-------------
PR: https://git.openjdk.org/jfx/pull/960
More information about the openjfx-dev
mailing list