RFR: 8294589: MenuBarSkin: memory leak when changing skin [v22]
John Hendrikx
jhendrikx at openjdk.org
Mon Dec 5 12:32:24 UTC 2022
On Fri, 2 Dec 2022 17:25:16 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().
>>
>> This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
>> See https://github.com/openjdk/jfx/pull/908
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 54 commits:
>
> - Merge remote-tracking branch 'origin/master' into
> 8294589.menubarskin.leak
> - 8294589: trying to avoid merge conflicts in the future
> - Merge remote-tracking branch 'origin/master' into
> 8294589.menubarskin.leak
> - 8294589: review comments
> - 8294589: review comments
> - Merge remote-tracking branch 'origin/master' into
> 8294589.menubarskin.leak
> - 8294589: review comments
> - 8294589: cleanup
> - Merge remote-tracking branch 'origin/master' into
> 8294589.menubarskin.leak
> - 8294589: testing github merge-conflict label behavior
> - ... and 44 more: https://git.openjdk.org/jfx/compare/e64e1292...d4e6141f
Marked as reviewed by jhendrikx (Author).
-------------
PR: https://git.openjdk.org/jfx/pull/906
More information about the openjfx-dev
mailing list