RFR: 8295175: SplitPaneSkin: memory leak when changing skin [v4]

[Andy Goryachev]

On Mon, 5 Dec 2022 12:05:16 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into
>>    8295175.splitpaneskin.with.helper
>>  - Merge remote-tracking branch 'origin/master' into
>>    8295175.splitpaneskin.with.helper
>>  - Merge remote-tracking branch 'origin/master' into 8295175.splitpaneskin.with.helper
>>  - Merge remote-tracking branch 'origin/master' into
>>    8295175.splitpaneskin.with.helper
>>  - Merge branch '8294809.listener.helper' into 8295175.splitpaneskin.with.helper
>>  - 8294809: generics
>>  - Merge branch '8294809.listener.helper' into 8295175.splitpaneskin.with.helper
>>  - 8294809: is alive
>>  - Merge branch '8294809.listener.helper' into 8295175.splitpaneskin.with.helper
>>  - Revert "8294809: removed weak listeners support"
>>    
>>    This reverts commit 2df4a85db638d76cacaf6c54ba669cdb3dd91a18.
>>  - ... and 19 more: https://git.openjdk.org/jfx/compare/e64e1292...fb7d9ea6
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/SplitPaneSkin.java line 627:
> 
>> 625:     }
>> 626: 
>> 627:     private void rebuildDividers(boolean removeAllDividers) {
> 
> Looks like this is unnecessary refactoring.
> Having a method to add dividers will be clearer than a method that tries to do 2 things based on input parameter.
> We already have `removeAllDividers()` method. Similarly if this method can be restricted to `addAllDividers()` (or simply `addDividers()`) the callers can make calls to 2 methods whenever required.

good point.  thanks!

-------------

PR: https://git.openjdk.org/jfx/pull/911