RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v4]

Andy Goryachev angorya at openjdk.org
Mon Dec 5 17:25:15 UTC 2022


On Mon, 5 Dec 2022 12:48:14 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Cause: When slider is dragged for first time after tooltip appears, setOnMousePressed event was not invoked, hence dragStart was null in the subsequently invoked event handler (setOnMouseDragged).
>> 
>> Fix: Initialized dragStart in initialize method.
>> 
>> Test: Added system test to validate the fix.
>> 
>> Note: Initializing dragStart in layoutChildren method as suggested in the bug was causing side effects. Hence initialized dragStart in initialize method.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update in mouse enter and exit events. Update in unit test

@aghaisas @karthikpandelu : 
could you guys check if this change fixes [JDK-8293916](https://bugs.openjdk.org/browse/JDK-8293916) ?
I don't have a touchscreen machine here, and these two bugs seem related.

-------------

PR: https://git.openjdk.org/jfx/pull/965


More information about the openjfx-dev mailing list