RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

Andy Goryachev angorya at openjdk.org
Mon Dec 5 21:20:49 UTC 2022


On Tue, 22 Nov 2022 22:34:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> I don't see it as a useful warning. The code isn't necessarily better without, and can be less clear. I think this might argue for asking Eclipse users to disable this warning in the IDE.
>
> I do agree with @kevinrushforth here.
> 
> It might be borderline useful to enable the warning once just to see if there are any bugs or perhaps to clean up the most obvious cases, but it probably makes little sense to enable the said warning for large and long lived code bases like this one.

just to clarify:
1. I am ok with this code change, the typecast is unnecessary
2. I agree with Kevin that this particular warning (unnecessary cast) is of little value, especially in the large and long lived code bases.

-------------

PR: https://git.openjdk.org/jfx/pull/960


More information about the openjfx-dev mailing list