RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

[John Hendrikx]

On Mon, 5 Dec 2022 20:37:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentations and merge short lines
>
> modules/javafx.graphics/src/main/java/com/sun/prism/d3d/D3DContext.java line 514:
> 
>> 512:             case D3DERR_DEVICEREMOVED:
>> 513:                 return "D3DERR_DEVICEREMOVED";
>> 514:             case D3D_OK:
> 
> this change is probably correct, but one can think of a theoretical possibility of collision, i.e.
> 
> `hResult = ((1L << 32) + D3DERR_DEVICENOTRESET)` will hit `D3DERR_DEVICENOTRESET` case instead of the default one.
> 
> but again, hResult is long perhaps because it's originally unsigned32 or something like that.

The code will not do anything different than it did already.  It casts `hResult` to `int` in the switch, if that's not intended, then that's a bug.

> modules/javafx.graphics/src/main/java/javafx/css/CssParser.java line 2579:
> 
>> 2577:             term = nextLayer(lastTerm);
>> 2578:         }
>> 2579:         return new ParsedValueImpl<>(layers, CornerRadiiConverter.getInstance());
> 
> My eclipse has a problem with this class (might be an Eclipse bug).  It does compile, but any time I modify the class it generates a bunch of errors.  The only code that does not produce the errors is returning a raw value.

You mentioned this one before.  It's a bug in Eclipse.

-------------

PR: https://git.openjdk.org/jfx/pull/960