RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

[Nir Lisker]

On Tue, 6 Dec 2022 03:03:13 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> The code was already broken (since 2014 apparently when the new Base64 decoder was used).  Had the author turned on these handy warnings, they would have noticed that something was amiss.  Now they unwittingly changed the behavior.
>> 
>> Personally, I think the current code is an improvement.  The catch block was already unreachable since 2014, and the `IllegalArgumentException` has been bubbling up and terminating the program since then (it's called from `launchApplication`).
>> 
>> Whether a follow-up bug is needed depends on whether we want to restore the original behavior: log an exception, ignore parsing the rest of the parameters and continue without them...  I think we shouldn't.
>
> I agree with you - we shouldn't.

This is an example of what I was talking about in [this comment](https://github.com/openjdk/jfx/pull/958#pullrequestreview-1198517697).

-------------

PR: https://git.openjdk.org/jfx/pull/960