RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

Nir Lisker nlisker at openjdk.org
Tue Dec 6 06:44:24 UTC 2022


On Wed, 30 Nov 2022 12:55:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java line 41:
>> 
>>> 39:  * The PresentingPainter is used when we are rendering to the main screen.
>>> 40:  */
>>> 41: final class UploadingPainter extends ViewPainter {
>> 
>> I'm not sure I see the value in making this change.
>
> Since this is an internal class (not public API), I won't object to this change. I do think it's a rather pointless change, but I'll leave it up to you.

Personally, I find that re-declaring type hierarchy is clutter. I can see why sometimes you might want to emphasize a functionality of a class that already exists, but the IDE makes it rather easy, I find.

-------------

PR: https://git.openjdk.org/jfx/pull/960


More information about the openjfx-dev mailing list