RFR: 8295175: SplitPaneSkin: memory leak when changing skin [v5]
Ajit Ghaisas
aghaisas at openjdk.org
Tue Dec 6 11:11:23 UTC 2022
On Mon, 5 Dec 2022 16:49:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Fixed memory leak by removing all the listeners in dispose();
>>
>> This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
>> See https://github.com/openjdk/jfx/pull/908
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 31 commits:
>
> - 8295175: review comments
> - Merge remote-tracking branch 'origin/master' into 8295175.splitpaneskin.with.helper
> - Merge remote-tracking branch 'origin/master' into
> 8295175.splitpaneskin.with.helper
> - Merge remote-tracking branch 'origin/master' into
> 8295175.splitpaneskin.with.helper
> - Merge remote-tracking branch 'origin/master' into 8295175.splitpaneskin.with.helper
> - Merge remote-tracking branch 'origin/master' into
> 8295175.splitpaneskin.with.helper
> - Merge branch '8294809.listener.helper' into 8295175.splitpaneskin.with.helper
> - 8294809: generics
> - Merge branch '8294809.listener.helper' into 8295175.splitpaneskin.with.helper
> - 8294809: is alive
> - ... and 21 more: https://git.openjdk.org/jfx/compare/bb98d886...3b30ba7a
Fix looks good to me!
-------------
Marked as reviewed by aghaisas (Reviewer).
PR: https://git.openjdk.org/jfx/pull/911
More information about the openjfx-dev
mailing list