RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v5]
Karthik P K
kpk at openjdk.org
Tue Dec 6 11:25:44 UTC 2022
> Cause: When slider is dragged for first time after tooltip appears, setOnMousePressed event was not invoked, hence dragStart was null in the subsequently invoked event handler (setOnMouseDragged).
>
> Fix: Initialized dragStart in initialize method.
>
> Test: Added system test to validate the fix.
>
> Note: Initializing dragStart in layoutChildren method as suggested in the bug was causing side effects. Hence initialized dragStart in initialize method.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
Address review comment. Add comments for changes
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/965/files
- new: https://git.openjdk.org/jfx/pull/965/files/26150c06..3e4de9c2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=965&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=965&range=03-04
Stats: 13 lines in 1 file changed: 8 ins; 0 del; 5 mod
Patch: https://git.openjdk.org/jfx/pull/965.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/965/head:pull/965
PR: https://git.openjdk.org/jfx/pull/965
More information about the openjfx-dev
mailing list