RFR: 8296621: Stage steals focus on scene change [v5]

[Kevin Rushforth]

On Tue, 6 Dec 2022 11:35:35 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> Simple fix to not requestFocus() on scene change.
>> 
>> The attached bug sample shows that the TextField focused on the scene remains focused when the scene comes back.
>
> Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 29 additional commits since the last revision:
> 
>  - Use utility class.
>  - Merge branch 'master' into 8296621_focus_stealing
>  - Merge branch 'openjdk:master' into master
>  - Add new line
>  - Use JUnit 5
>  - Add test
>  - 8296621 - Stage steals focus on scene change
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - ... and 19 more: https://git.openjdk.org/jfx/compare/3f2d3ce1...8ce83fde

One other thing to note about the test, and also about the test case from the bug report on which it was based: The fact that the test sets the scene in rapid succession to two different values (at time = N, and immediately thereafter at time = 0) has uncovered a bug in JavaFX. I see an intermittent NPE in `Window::adjustSize` with a scene that is transiently null. I'll submit a new bug with a modified version of the test program attached to this bug.

-------------

PR: https://git.openjdk.org/jfx/pull/940