RFR: 8245145: Spinner: throws IllegalArgumentException when replacing skin [v5]
Andy Goryachev
angorya at openjdk.org
Tue Dec 6 23:46:47 UTC 2022
> Fixed SpinnerSkin initialization using new Skin.install(). Also in this PR - fixing memory leaks in SpinnerSkin by properly removing all listeners and event filters added in the constructor, as well as any child Nodes.
>
> NOTE: the fix requires both ListenerHelper [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) and Skin.install() [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.
Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
8245145: space
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/904/files
- new: https://git.openjdk.org/jfx/pull/904/files/f83fc9d6..5c4880af
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=904&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=904&range=03-04
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jfx/pull/904.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/904/head:pull/904
PR: https://git.openjdk.org/jfx/pull/904
More information about the openjfx-dev
mailing list