RFR: 8245145: Spinner: throws IllegalArgumentException when replacing skin [v5]

Ajit Ghaisas aghaisas at openjdk.org
Wed Dec 7 02:23:16 UTC 2022


On Tue, 6 Dec 2022 23:46:47 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Fixed SpinnerSkin initialization using new Skin.install().  Also in this PR - fixing memory leaks in SpinnerSkin by properly removing all listeners and event filters added in the constructor, as well as any child Nodes.
>> 
>> NOTE: the fix requires both ListenerHelper [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) and Skin.install() [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8245145: space

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.org/jfx/pull/904


More information about the openjfx-dev mailing list