Integrated: 8245145: Spinner: throws IllegalArgumentException when replacing skin

Andy Goryachev angorya at openjdk.org
Wed Dec 7 16:13:07 UTC 2022


On Wed, 28 Sep 2022 15:08:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Fixed SpinnerSkin initialization using new Skin.install().  Also in this PR - fixing memory leaks in SpinnerSkin by properly removing all listeners and event filters added in the constructor, as well as any child Nodes.
> 
> NOTE: the fix requires both ListenerHelper [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) and Skin.install() [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.

This pull request has now been integrated.

Changeset: 07e693b5
Author:    Andy Goryachev <angorya at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/07e693b52f54dd92ee055de7c51f173902dda583
Stats:     60 lines in 3 files changed: 35 ins; 12 del; 13 mod

8245145: Spinner: throws IllegalArgumentException when replacing skin

Reviewed-by: aghaisas, kcr

-------------

PR: https://git.openjdk.org/jfx/pull/904


More information about the openjfx-dev mailing list