RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

[Karthik P K]

On Thu, 8 Dec 2022 18:53:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/DatePickerUpdateOnAlertCloseTest.java line 25:
> 
>> 23:  * questions.
>> 24:  */
>> 25: package test.robot.javafx.scene;
> 
> Minor: as long as you are removing the blank like Andy pointed out, you can add a missing blank line here. :)

Added new line

> tests/system/src/test/java/test/robot/javafx/scene/DatePickerUpdateOnAlertCloseTest.java line 121:
> 
>> 119:                     datePicker.getLayoutY() + datePicker.getHeight() * Y_FACTOR);
>> 120: 
>> 121:         Assert.assertFalse(LocalDate.now().isEqual(datePicker.getValue()));
> 
> Do you need a small sleep here? It works for me without it on Windows, but I haven't tried it on my slow Ubuntu 20.04 VM.

Even I checked on Windows machine itself which is quite good in configuration. Added small delay of 400ms similar to the delay present where we wait for date picker popup.

-------------

PR: https://git.openjdk.org/jfx/pull/963