RFR: 8295339: DatePicker updates its value property with wrong date when dialog closes [v2]

[Marius Hanl]

On Fri, 9 Dec 2022 06:49:55 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java line 145:
>> 
>>> 143:                 show();
>>> 144:             } else {
>>> 145:                 updateDisplayNode();
>> 
>> Can the call to `updateDisplayNode();` be removed in line 128 then?
>> Just asking, since `updateDisplayNode();` is now called two times. But it looks like this is also still needed..
>
> I believe `updateDisplayNode()` in line 128 is required as it is the event handler on `valueProperty`.

I think so too.

-------------

PR: https://git.openjdk.org/jfx/pull/963