RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v2]

John Hendrikx jhendrikx at openjdk.org
Sat Dec 10 08:23:08 UTC 2022


On Thu, 8 Dec 2022 19:38:02 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert renames in Disposer
>
> modules/javafx.base/src/main/java/com/sun/javafx/property/adapter/PropertyDescriptor.java line 177:
> 
>> 175:             if (bean.equals(propertyChangeEvent.getSource()) && name.equals(propertyChangeEvent.getPropertyName())) {
>> 176:                 final ReadOnlyJavaBeanProperty<T> property = checkRef();
>> 177:                 if ((property instanceof Property) && (((Property<?>)property).isBound()) && !updating) {
> 
> This line can be
> 
> if ((property instanceof Property<?> prop) && prop.isBound() && !updating) {
> 
> with perhaps better naming.

Yes, good suggestion, changed.

-------------

PR: https://git.openjdk.org/jfx/pull/969


More information about the openjfx-dev mailing list