RFR: JDK-8298060: Fix precision bug in gesture recognizer classes

Ambarish Rapte arapte at openjdk.org
Mon Dec 12 05:43:47 UTC 2022


On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> This includes a fix for the precision problem we've found as part of the graphics warnings clean ups.
> 
> I've included two commits, one with just the minimal fix, and one with the clean ups. I can drop off the 2nd commit if it is deemed to be of no added value.

The commit#1 changes look good.
I would recommend to revert commit#2 for few reasons:
1. Cleanup changes are a lot more than actual fix change.
2. It will be difficult to revisit in future.
3. If required the cleanup changes could go in as a separate fix.

Could you please provide link to the discussion that led to this change?

-------------

PR: https://git.openjdk.org/jfx/pull/966


More information about the openjfx-dev mailing list