RFR: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting [v15]

Kevin Rushforth kcr at openjdk.org
Thu Dec 15 13:05:14 UTC 2022


On Thu, 15 Dec 2022 01:27:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Setting a null selection model in TableView and TreeTableView produce NPE on sorting (and probably in some other situations) because the check for null is missing in several places. 
>> 
>> Setting a null selection model is a valid way to disable selection in a (tree)table.
>> 
>> There is also a similar issue with ListView [JDK-8279640](https://bugs.openjdk.org/browse/JDK-8279640).
>> 
>> changes:
>> - added check for null selection model where it was missing
>> - clear focused row index on setting null selection model in TreeTableView
>> - clear selected cells on setting a new selection model
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8187145: formatting

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.org/jfx/pull/876


More information about the openjfx-dev mailing list