Integrated: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting
Andy Goryachev
angorya at openjdk.org
Thu Dec 15 16:05:27 UTC 2022
On Thu, 18 Aug 2022 16:24:11 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> Setting a null selection model in TableView and TreeTableView produce NPE on sorting (and probably in some other situations) because the check for null is missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a (tree)table.
>
> There is also a similar issue with ListView [JDK-8279640](https://bugs.openjdk.org/browse/JDK-8279640).
>
> changes:
> - added check for null selection model where it was missing
> - clear focused row index on setting null selection model in TreeTableView
> - clear selected cells on setting a new selection model
This pull request has now been integrated.
Changeset: 58376eb8
Author: Andy Goryachev <angorya at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/58376eb844866f7e2fea726865eb2f821b09752f
Stats: 469 lines in 15 files changed: 378 ins; 12 del; 79 mod
8187145: (Tree)TableView with null selectionModel: throws NPE on sorting
Reviewed-by: aghaisas, kcr
-------------
PR: https://git.openjdk.org/jfx/pull/876
More information about the openjfx-dev
mailing list