RFR: 8252863: Spinner keeps spinning if removed from Scene [v2]

Karthik P K kpk at openjdk.org
Mon Dec 19 07:20:12 UTC 2022


On Sat, 17 Dec 2022 19:56:59 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use ListenerHelper for sceneProperty
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SpinnerSkinTest.java line 178:
> 
>> 176:         assertEquals(Status.RUNNING, SpinnerBehaviorShim.getTimeline(behavior).getStatus());
>> 177:         root.getChildren().clear();
>> 178:         assertEquals(Status.STOPPED, SpinnerBehaviorShim.getTimeline(behavior).getStatus());
> 
> just curious: if we add the spinner back to the scene, should it spin again?  do we want  to add this condition to this test?

It should not spin again. Added the same condition in the test. Please check

-------------

PR: https://git.openjdk.org/jfx/pull/976


More information about the openjfx-dev mailing list