RFR: 8292922 - [Linux] No more drag events when new Stage is created in drag handler [v3]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Dec 19 13:14:56 UTC 2022


On Sun, 18 Dec 2022 21:02:20 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> This PR  was previously discussed on #905.
>> 
>> The approach is to grab the keyboard focus so the window that originated the drag will keep it.
>> 
>> I did some cleanup on grabbing related functions as well.
>> 
>> `gdk_keyboard_focus()` is deprecated, so is `gdk_device*` functions in favor of `gdk_seat*`. But that's only available in later Gtk versions. I checked and newer Gtk will use `gdk_seat*` inside the deprecated `gdk_keyboard_focus()`.
>
> Thiago Milczarek Sayao has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8292922 - [Linux] No more drag events when new Stage is created in drag handler

I had another idea to approach this, will test tonight if time permits.

One thing that bugs me is that it's grabbing on click, it probably should grab on drag detection. Let me know it this change would be welcome.

-------------

PR: https://git.openjdk.org/jfx/pull/977


More information about the openjfx-dev mailing list