RFR: 8252863: Spinner keeps spinning if removed from Scene [v3]

Andy Goryachev angorya at openjdk.org
Mon Dec 19 16:46:59 UTC 2022


On Mon, 19 Dec 2022 07:20:11 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Spinner was not stopping because it was getting removed from scene before the mouse release event handler was getting invoked.
>> 
>> Added listener for `sceneProperty` so that when Spinner is removed from the scene, `stopSpinning` method shall be called.
>> 
>> Added unit test to validate the fix
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

excellent, thank you!

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/976


More information about the openjfx-dev mailing list